Forum PHP.pl

Witam,
mam mały problem z rejestracja uzytkowników na stronie,
posiadam mały skrypt na rejestracje, jednakże przy rejestracji, wyświetla błąd,
"Error in signup procedure".

W czym może być problem?
Oto skrypt:

[PHP] pobierz, plaintext 
<?php
session_start();
// include config file
require_once("config.php");
// include files
require_once(INC_ROOT."/dblayer.php");
require_once(INC_ROOT."/system.php");
require_once(INC_ROOT."/users.php");
 
// initialise db access
global $db;
$db = new MySQL();
$db->connect();
 
$showform = false;
$err_msg = '';
$redirect_to = WEB_ROOT.'/home.php';
 
if ( isset($_POST['signup']) ) { // form was submitted and try to signup user
  $username = $_POST['username'];
  $password = $_POST['password'];
  $password2 = $_POST['password2'];
  $email = $_POST['email'];
 
  if ( $password == $password2 ) {
    if ( !user_load('',$username) ) {
      if ( user_signup($username, $password, $email) ) {
        $showform = false;
        user_login($username, $password); // chg this for different authentication method
        $u = user_load($username);
        // print_r($u);
        header("Location: http://" . $_SERVER['HTTP_HOST'] .$redirect_to);
      } else {
        echo "Error in signup procedure";
      }
    } else {
      $showform = true;
      $err_msg = 'Username already exists. Please choose another username';
    }
  } else {
    $showform = true;
    $err_msg = 'Both passwords should be identical.';
  }
} else { // no form was submitted
  $showform = true;
}
 
if ( $showform ) {
 
  if ( is_login() ) { // logged in 
    header("Location: http://" . $_SERVER['HTTP_HOST'] .$redirect_to);
  } else { // not yet logged in
    $qb_title = 'konto utworzone';
    include("inc/header-meta.inc");
    include("inc/qb-static-header.inc");
    include("inc/grey-header.inc");
    include("inc/content-signup.inc");
    include("inc/content-footer.inc");
    include("inc/grey-footer.inc");
    include("inc/qb-static-footer.inc");
  }
}
?>
[PHP] pobierz, plaintext 

Pozdrawiam.

Metoda user_signup() zwraca ci FALSE

Zmiana na true, nie poprawia nic.

A niby jak ty zmieniles to? Gdyby ta metoda zwracała TRUE to bys w zyciu nie dostał "Error in signup procedure", gdyz ten komunikat leci zawsze gdy ta metoda zwraca FALSE więc mnie tu nie czaruj ze cos zmieniles

A więc miłościwie panujący, jak naprawić problem który opisałem?

A niby skąd mam wiedziec? Nie mam zielonego pojęcia jak wygląda funkcja user_signup()

A jakoże Ci ja ją ukazać?

Ty się głupio nie pytać, ty pokazać

to pokazem user.php:

[PHP] pobierz, plaintext 
<?php
 
 
require_once("system.php");
 
Class User {
 
  //treat as read-only variables
  //identity
  var $user_id;
  var $username;
  var $name;
  var $nickname;
  var $email;
 
 
  function get_blogs_user_owns()
  {
    global $db;
 
    if ( $db->query("SELECT blog_name FROM blogs WHERE blog_owner_id = '$this->user_id';") ) {
      $blogs_user_owns = array();
      for ( $i=0 ; $i < $db->num_rows() ; $i++ ) {
        $row = $db->fetch_array();
        $blogs_user_owns[] = $row['blog_name'];
      }
      return $blogs_user_owns;
    } else {
      return set_error("get_blogs_u_owns(): db query".$db->error());
    }
  }
 
  function get_blogs_user_mods()
  {
    global $db;
 
 
    if ( $db->query("SELECT blog_name FROM mods WHERE mod_id = '$this->user_id' ;") ) {
      $blogs_user_mods = array();
      for ( $i=0 ; $i<$db->num_rows() ; $i++ ) {
        $row = $db->fetch_array();
        $blogs_user_mods[] = $row['blog_name'];
      }
      return $blogs_user_mods;
    } else {
        return set_error("get_blogs_u_mods(): db query".$db->error());
    }
  }
 
  function set_user_type($blog_name)
  {
    global $CUR_USER;
 
    $blogs_user_owns = array();
    $blogs_user_owns = $this->get_blogs_user_owns();
 
    $blogs_user_mods = array();
    $blogs_user_mods = $this->get_blogs_user_mods();
 
    if ( in_array($blog_name,$blogs_user_owns) ) {
      $CUR_USER = BLOG_OWNER;
    } else if ( in_array($blog_name,$blogs_user_mods) ) {
      $CUR_USER = BLOG_MOD;
    } else {
      $CUR_USER = BLOG_GUEST;
    }
    //echo $CUR_USER;
    return true;
  }
}
 
// user signsup for the service
function user_signup($username, $password, $email, $name='', $nickname='')
{
  global $db;
 
  $username = strtolower(trim($username));
  $email = strtolower(trim($email));
  $password = md5($password); // not modifying the password at all... so clever of me ;-)
 
  /* Username can be  
  if ( $name = '' ) {
    $name = $username;
  }
  */
  if ( $nickname = '' ) {
    $nickname = $username;
  }
  if ( $name = '' ) {
    $name = $username;
  }
 
  if ( !$username || !$email ) {
    return set_error("user_signup(): invalid username or email");
  } else {
    if ( !$db->dbh ) {
      return set_error("user_signup():Invalid db handle".$db->error());
    } else {
      if( user_load('',$username) ) {
        return set_error("user_signup():User exists");
      } else {
        // if ( $db->query("INSERT INTO users(username,name,nickname,email) values('$username','$name','$nickname','$email')") ) {
        if ( $db->query("INSERT INTO users(username,password,name,nickname,email) values('$username','$password','$name','$nickname','$email')") ) {
          return true;
        } else {
          return set_error("user_signup(): error in insert query".$db->error());
        }
      }
    }
  }
}
 
// authenticates a user, returns TRUE on sucessful authentication
function user_authenticate($username,$password)
{
  global $db;
  /*
  if ( $username == $password ) {
    return true;
  }
  */
 
  $password = md5($password);
 
  if ( !$db->dbh ) {
    return set_error("user_authenticate():Invalid db handle".$db->error());
  } else {
    if ( $db->query("SELECT username FROM users WHERE username='$username' AND password ='$password'") ) {
      if ( $db->num_rows() == 1 ) {
        return true;
      } else {
        return false;
      }
    } else {
      return set_error("user_signup(): error in insert query".$db->error());
    }
  }
 
  return false;
}
 
// logs in the user and sets CUR_USER global var appropriately admin for admin and username for mods
function user_login($username,$password)
{
  $username = strtolower($username);
 
  if ( user_authenticate($username,$password) ) {
    $_SESSION['username'] = $username;
    return true;
  } else {
    return set_error("Invalid username or password");
  }
}
 
//loads the user with username $username and returns an object of type User
function user_load($user_id='', $username='')
{
  global $db;
 
  if ( !$db->dbh ) 
    return set_error("user_load():Invalid database handle");
 
  $username = trim($username);
  $user_id = trim($user_id);
  if ( !$username && !$user_id )
    return set_error("user_load():user_id OR username is required to load.");
 
  if ( $user_id != '' ) {
    if ($db->query("SELECT * FROM users WHERE user_id = '$user_id';")) {
      if ( $db->num_rows() == 1 ) {
        $row = $db->fetch_array();
 
        $u = new User();
        _user_load($row,$u);
 
        return $u;
      } else {
        set_error("user_load():userid doesnt exists".$db->error());
      }//i guess i can remove the else part
    } else {
      //print db->error();
      return set_error("user_load():".$db->error());
    }
  } else {
    if ($db->query("SELECT * FROM users WHERE username = '$username';")) {
 
      if ( $db->num_rows() == 1 ) {
        $row = $db->fetch_array();
 
        $u = new User();
        _user_load($row,$u);
 
        return $u;
      } else {
        set_error("user_load():username doesnt exists".$db->error());
      }//i guess i can remove the else part
    } else {
      //print db->error();
      return set_error("user_load():".$db->error());
    }
  }
}
 
 
function _user_load(&$row, &$obj) 
{
  //identity
  $obj->user_id = $row['user_id'];
  $obj->username = $row['username'];
  $obj->name = $row['name'];
  $obj->nickname = $row['nickname'];
  $obj->email = $row['email'];
}
 
function is_login() {
  if ( isset($_SESSION['username']) ) {
    return true;
  } else {
    return false;
  }
}
?>
[PHP] pobierz, plaintext 

Masz tam mase return. Postaw przed każdym
echo '1';
echo '2';
echo '...';
A dowiesz na którym sie wywalil. No włącz troche samodzielnosci

To dając to co proponujesz, to przy pierwszym return wpada błąd,
"Parse error: syntax error, unexpected T_ELSE in /usr/home/***/domains/*****.pl/public_html/test/qb/include/users.php on line 27"

Pokaz jak wstawiles bo zrobiles to źle
No jak można tak proste echo '1'; zepsuc?

[PHP] pobierz, plaintext 
<?php
 
 
require_once("system.php");
 
Class User {
 
  //treat as read-only variables
  //identity
  var $user_id;
  var $username;
  var $name;
  var $nickname;
  var $email;
 
 
  function get_blogs_user_owns()
  {
    global $db;
 
    if ( $db->query("SELECT blog_name FROM blogs WHERE blog_owner_id = '$this->user_id';") ) {
      $blogs_user_owns = array();
      for ( $i=0 ; $i < $db->num_rows() ; $i++ ) {
        $row = $db->fetch_array();
        $blogs_user_owns[] = $row['blog_name'];
      }
      else "1"; return $blogs_user_owns;
    } else 
      else '2'; return set_error("get_blogs_u_owns(): db query".$db->error());
    }
  }
 
  function get_blogs_user_mods()
  {
    global $db;
 
 
    if ( $db->query("SELECT blog_name FROM mods WHERE mod_id = '$this->user_id' ;") ) {
      $blogs_user_mods = array();
      for ( $i=0 ; $i<$db->num_rows() ; $i++ ) {
        $row = $db->fetch_array();
        $blogs_user_mods[] = $row['blog_name'];
      }
     else '3'; return $blogs_user_mods;
    } else {
       else '4'; return set_error("get_blogs_u_mods(): db query".$db->error());
    }
  }
 
  function set_user_type($blog_name)
  {
    global $CUR_USER;
 
    $blogs_user_owns = array();
    $blogs_user_owns = $this->get_blogs_user_owns();
 
    $blogs_user_mods = array();
    $blogs_user_mods = $this->get_blogs_user_mods();
 
    if ( in_array($blog_name,$blogs_user_owns) ) {
      $CUR_USER = BLOG_OWNER;
    } else if ( in_array($blog_name,$blogs_user_mods) ) {
      $CUR_USER = BLOG_MOD;
    } else {
      $CUR_USER = BLOG_GUEST;
    }
    //echo $CUR_USER;
    else '5'; return true;
  }
}
 
// user signsup for the service
function user_signup($username, $password, $email, $name='', $nickname='')
{
  global $db;
 
  $username = strtolower(trim($username));
  $email = strtolower(trim($email));
  $password = md5($password); // not modifying the password at all... so clever of me ;-)
 
  /* Username can be  
  if ( $name = '' ) {
    $name = $username;
  }
  */
  if ( $nickname = '' ) {
    $nickname = $username;
  }
  if ( $name = '' ) {
    $name = $username;
  }
 
  if ( !$username || !$email ) {
    else '6'; return set_error("user_signup(): invalid username or email");
  } else {
    if ( !$db->dbh ) {
      else '7'; return set_error("user_signup():Invalid db handle".$db->error());
    } else {
      if( user_load('',$username) ) {
        else '8'; return set_error("user_signup():User exists");
      } else {
        // if ( $db->query("INSERT INTO users(username,name,nickname,email) values('$username','$name','$nickname','$email')") ) {
        if ( $db->query("INSERT INTO users(username,password,name,nickname,email) values('$username','$password','$name','$nickname','$email')") ) {
          else '9'; return true;
        } else {
          else '10'; return set_error("user_signup(): error in insert query".$db->error());
        }
      }
    }
  }
}
 
// authenticates a user, returns TRUE on sucessful authentication
function user_authenticate($username,$password)
{
  global $db;
  /*
  if ( $username == $password ) {
    return true;
  }
  */
 
  $password = md5($password);
 
  if ( !$db->dbh ) {
    return set_error("user_authenticate():Invalid db handle".$db->error());
  } else {
    if ( $db->query("SELECT username FROM users WHERE username='$username' AND password ='$password'") ) {
      if ( $db->num_rows() == 1 ) {
        return true;
      } else {
        return false;
      }
    } else {
      return set_error("user_signup(): error in insert query".$db->error());
    }
  }
 
  return false;
}
 
// logs in the user and sets CUR_USER global var appropriately admin for admin and username for mods
function user_login($username,$password)
{
  $username = strtolower($username);
 
  if ( user_authenticate($username,$password) ) {
    $_SESSION['username'] = $username;
    return true;
  } else {
    return set_error("Invalid username or password");
  }
}
 
//loads the user with username $username and returns an object of type User
function user_load($user_id='', $username='')
{
  global $db;
 
  if ( !$db->dbh ) 
    return set_error("user_load():Invalid database handle");
 
  $username = trim($username);
  $user_id = trim($user_id);
  if ( !$username && !$user_id )
    return set_error("user_load():user_id OR username is required to load.");
 
  if ( $user_id != '' ) {
    if ($db->query("SELECT * FROM users WHERE user_id = '$user_id';")) {
      if ( $db->num_rows() == 1 ) {
        $row = $db->fetch_array();
 
        $u = new User();
        _user_load($row,$u);
 
        return $u;
      } else {
        set_error("user_load():userid doesnt exists".$db->error());
      }//i guess i can remove the else part
    } else {
      //print db->error();
      return set_error("user_load():".$db->error());
    }
  } else {
    if ($db->query("SELECT * FROM users WHERE username = '$username';")) {
 
      if ( $db->num_rows() == 1 ) {
        $row = $db->fetch_array();
 
        $u = new User();
        _user_load($row,$u);
 
        return $u;
      } else {
        set_error("user_load():username doesnt exists".$db->error());
      }//i guess i can remove the else part
    } else {
      //print db->error();
      return set_error("user_load():".$db->error());
    }
  }
}
 
 
function _user_load(&$row, &$obj) 
{
  //identity
  $obj->user_id = $row['user_id'];
  $obj->username = $row['username'];
  $obj->name = $row['name'];
  $obj->nickname = $row['nickname'];
  $obj->email = $row['email'];
}
 
function is_login() {
  if ( isset($_SESSION['username']) ) {
    return true;
  } else {
    return false;
  }
}
?>
[PHP] pobierz, plaintext 

rety.... znajdz 10 roznic
echo '1';
else '1';

załamka.

Fakt moja pomyłka. Jednak przy echo, wystąpuje nadal problem "Error in signup procedure".

[PHP] pobierz, plaintext 
<?php
 
 
require_once("system.php");
 
Class User {
 
  //treat as read-only variables
  //identity
  var $user_id;
  var $username;
  var $name;
  var $nickname;
  var $email;
 
 
  function get_blogs_user_owns()
  {
    global $db;
 
    if ( $db->query("SELECT blog_name FROM blogs WHERE blog_owner_id = '$this->user_id';") ) {
      $blogs_user_owns = array();
      for ( $i=0 ; $i < $db->num_rows() ; $i++ ) {
        $row = $db->fetch_array();
        $blogs_user_owns[] = $row['blog_name'];
      }
      echo "1"; return $blogs_user_owns;
    } else 
      echo '2'; return set_error("get_blogs_u_owns(): db query".$db->error());
    }
  }
 
  function get_blogs_user_mods()
  {
    global $db;
 
 
    if ( $db->query("SELECT blog_name FROM mods WHERE mod_id = '$this->user_id' ;") ) {
      $blogs_user_mods = array();
      for ( $i=0 ; $i<$db->num_rows() ; $i++ ) {
        $row = $db->fetch_array();
        $blogs_user_mods[] = $row['blog_name'];
      }
     echo '3'; return $blogs_user_mods;
    } else {
       echo '4'; return set_error("get_blogs_u_mods(): db query".$db->error());
    }
  }
 
  function set_user_type($blog_name)
  {
    global $CUR_USER;
 
    $blogs_user_owns = array();
    $blogs_user_owns = $this->get_blogs_user_owns();
 
    $blogs_user_mods = array();
    $blogs_user_mods = $this->get_blogs_user_mods();
 
    if ( in_array($blog_name,$blogs_user_owns) ) {
      $CUR_USER = BLOG_OWNER;
    } else if ( in_array($blog_name,$blogs_user_mods) ) {
      $CUR_USER = BLOG_MOD;
    } else {
      $CUR_USER = BLOG_GUEST;
    }
    //echo $CUR_USER;
    echo '5'; return true;
  }
}
 
// user signsup for the service
function user_signup($username, $password, $email, $name='', $nickname='')
{
  global $db;
 
  $username = strtolower(trim($username));
  $email = strtolower(trim($email));
  $password = md5($password); // not modifying the password at all... so clever of me ;-)
 
  /* Username can be  
  if ( $name = '' ) {
    $name = $username;
  }
  */
  if ( $nickname = '' ) {
    $nickname = $username;
  }
  if ( $name = '' ) {
    $name = $username;
  }
 
  if ( !$username || !$email ) {
    echo '6'; return set_error("user_signup(): invalid username or email");
  } else {
    if ( !$db->dbh ) {
      echo '7'; return set_error("user_signup():Invalid db handle".$db->error());
    } else {
      if( user_load('',$username) ) {
        echo '8'; return set_error("user_signup():User exists");
      } else {
        // if ( $db->query("INSERT INTO users(username,name,nickname,email) values('$username','$name','$nickname','$email')") ) {
        if ( $db->query("INSERT INTO users(username,password,name,nickname,email) values('$username','$password','$name','$nickname','$email')") ) {
          echo '9'; return true;
        } else {
          echo '10'; return set_error("user_signup(): error in insert query".$db->error());
        }
      }
    }
  }
}
 
// authenticates a user, returns TRUE on sucessful authentication
function user_authenticate($username,$password)
{
  global $db;
  /*
  if ( $username == $password ) {
    return true;
  }
  */
 
  $password = md5($password);
 
  if ( !$db->dbh ) {
    echo '11'; return set_error("user_authenticate():Invalid db handle".$db->error());
  } else {
    if ( $db->query("SELECT username FROM users WHERE username='$username' AND password ='$password'") ) {
      if ( $db->num_rows() == 1 ) {
        echo '12'; return true;
      } else {
        echo '13'; return false;
      }
    } else {
      echo '14';return set_error("user_signup(): error in insert query".$db->error());
    }
  }
 
  return false;
}
 
// logs in the user and sets CUR_USER global var appropriately admin for admin and username for mods
function user_login($username,$password)
{
  $username = strtolower($username);
 
  if ( user_authenticate($username,$password) ) {
    $_SESSION['username'] = $username;
    echo '15'; return true;
  } else {
    echo '16'; return set_error("Invalid username or password");
  }
}
 
//loads the user with username $username and returns an object of type User
function user_load($user_id='', $username='')
{
  global $db;
 
  if ( !$db->dbh ) 
    echo '17'; return set_error("user_load():Invalid database handle");
 
  $username = trim($username);
  $user_id = trim($user_id);
  if ( !$username && !$user_id )
    echo '18'; return set_error("user_load():user_id OR username is required to load.");
 
  if ( $user_id != '' ) {
    if ($db->query("SELECT * FROM users WHERE user_id = '$user_id';")) {
      if ( $db->num_rows() == 1 ) {
        $row = $db->fetch_array();
 
        $u = new User();
        _user_load($row,$u);
 
        echo '19'; return $u;
      } else {
        set_error("user_load():userid doesnt exists".$db->error());
      }//i guess i can remove the else part
    } else {
      //print db->error();
      echo '20'; return set_error("user_load():".$db->error());
    }
  } else {
    if ($db->query("SELECT * FROM users WHERE username = '$username';")) {
 
      if ( $db->num_rows() == 1 ) {
        $row = $db->fetch_array();
 
        $u = new User();
        _user_load($row,$u);
 
        echo '21'; return $u;
      } else {
        set_error("user_load():username doesnt exists".$db->error());
      }//i guess i can remove the else part
    } else {
      //print db->error();
      echo '22';return set_error("user_load():".$db->error());
    }
  }
}
 
 
function _user_load(&$row, &$obj) 
{
  //identity
  $obj->user_id = $row['user_id'];
  $obj->username = $row['username'];
  $obj->name = $row['name'];
  $obj->nickname = $row['nickname'];
  $obj->email = $row['email'];
}
 
function is_login() {
  if ( isset($_SESSION['username']) ) {
    echo '23'; return true;
  } else {
    echo '24'; return false;
  }
}
?>
[PHP] pobierz, plaintext 

No a od kiedy diagnozna naprawia bledy?
Robiąc echo miales stwierdzic na którym return ci się wywalil, poprzez zobaczenie na ekranie jeszcze liczby. POjawila ci się na ekranie jeszcze jakaś liczba? Tuż przed Twoim nieszczesnym komunikatem bledu?

Jakoby się ona pojawiła, dał bym znać. Jednakże żadna liczba się nie pojawia.

A to już dla mnie pewnikiem nie było. Nie raz się na tym zawiodłem (i nie, nie mam na mysli ciebie)

No to skoro się nic nie pojawia to dziwne. metoda user_signup() powinna dać jakieś echo. Na pewno modyfikujesz to co trzeba? A w źródle strony, też nie ma tej liczby?

Jednak jest liczba, 6. Po dodaniu users.php, do drugiego folderu include, okazje się "6Error in signup procedure".

if ( !$username || !$email ) {
echo '6'; return set_error("user_signup(): invalid username or email");
}

No i teraz wnioski wyciągnij sam