Forum PHP.pl

skrypt pobiera mi dane z bazy i pokazuje je w formularzu, ale jak chce je zminie i chce zaktualizowac to wywala mi blad:

[PHP] pobierz, plaintext 
Notice: Undefined index: id in F:\EasyPHP-12.1\www\glencaldy\editstudent.php on line 33
[PHP] pobierz, plaintext 

w tabeli 'student' mam pola: studentid, firstname, surname, username, password. chce zeby moliwa byla edycja wsyzstkich poza studentid.
jak zmienialem w tej 33 lini id na student id to wogole nie pobiera danych i nie wyskakuje ten blad juz na glownej stronie. oto kod mojego skryptu edycji danych. moglby ktos mi pomoc z tym albo dac jakies wskazowki? musze to skonczyc do szkoly w tym tygodniiu

[PHP] pobierz, plaintext 
 <?php
 
// Connects to your Database
 
mysql_connect("localhost", "root", "") or die(mysql_error());
 
mysql_select_db("glencaldy") or die(mysql_error());
 
 
//checks cookies to make sure they are logged in
 
if (isset($_COOKIE['ID_my_site'])) {
    $username = $_COOKIE['ID_my_site'];
 
    $pass = $_COOKIE['Key_my_site'];
 
    $check = mysql_query("SELECT * FROM student WHERE username = '$username'") or die(mysql_error());
 
    while ($info = mysql_fetch_array($check)) {
        //if the cookie has the wrong password, they are taken to the login page
 
        if ($pass != $info['password']) {
            header("Location: login.php");
 
        }
 
 
 
        //otherwise they are shown the admin area   
 
        else {
            $a  = trim($_REQUEST['a']);
            $id = trim($_GET['id']);
            if ($a == 'edit' and !empty($id)) {
                $result = mysql_query("SELECT * FROM student WHERE
    studentid='$id'") or die('Error');
 
                if (mysql_num_rows($result) > 0) {
                    // read content of table
                    $r = mysql_fetch_assoc($result);
                    echo "<h1>EDIT STUDENT</h1><p>";
                    echo '<form action="editstudent.php" method="post">
        <input type="hidden" name="a" value="save" />
        <input type="hidden" name="studentid" value="' . $id . '" />
        First name:<br />
        <input type="text" name="firstname"
        value="' . $r['firstname'] . '" /><br />
        Surname:<br />
        <input type="text" name="surname"
        value="' . $r['surname'] . '" /><br />
      Username:<br />
        <input type="text" name="username"
        value="' . $r['username'] . '" /><br />
      Password:<br />
        <input type="text" name="password"
        value="' . $r['password'] . '" /><br />
        <input type="submit" value="Update Record" />
        </form>';
                    echo "<a href=deletestudent.php><< Back to delete/edit menu</a><p>";
                    echo "<a href=menu.php><< Back to main menu</a><p>";
 
                }
 
            }
        }
 
    }
} elseif ($a == 'save') {
    // get the new records from form
    $id        = $_POST['studentid'];
    $firstname = trim($_POST['firstname']);
    $surname   = trim($_POST['surname']);
    $username  = trim($_POST['username']);
    $password  = trim($_POST['password']);
    // update table
    mysql_query("UPDATE studnet SET firstname='$firstname',
    surname='$surname', username='&username', password='$password' WHERE studentid='$id'") or die('Error');
    echo 'records updated';
}
 
else
//if the cookie does not exist, they are taken to the login screen
    {
    header("Location: login.php");
 
}
 
?>
[PHP] pobierz, plaintext 

tutaj wrzucam paczke z calym skryptem: https://dl.dropbox.com/u/63492647/glencaldy_dp.zip

Komunikat błędu przecież ci wyraźnie mówi co masz źle i w której linijce....
$id = trim($_GET['id']);
W _GET nie masz indeksu ID. Przesyłasz to ID? Przesyłasz GETem czy POSTem?

ok wiec zamienilem:

[PHP] pobierz, plaintext 
$id = trim($_GET['id']);
[PHP] pobierz, plaintext 

na

[PHP] pobierz, plaintext 
if(isset($_GET['id']))
    $id = trim($_GET['id']);
else
    $id = '';
[PHP] pobierz, plaintext 

teraz nie wyskakuje notice ani zaden blad ale nie zmieniaja sie dane w bazie danych

Rety.... zadałem proste pytania:
Odpowiedz na nie bo to one są kluczem do rozwiązanie tej niesamowitej zagadki....
Skoro nie ma ID to niewyświetlanie błędu ci nie rozwiąze problemu, skoro ty polegasz na danych z tego ID....

przepraszam, postem.

No to skoro postem wysyłasz to czego szukasz go w $_GET?

blad poczatkujacego? (IMG:style_emoticons/default/smile.gif) kasowanie rekordow z bazy zrobilem GETem i dziala to dlaczego edycja nie ddziala GETem?

Rety..... skoro dane wysyłąsz POSTEM to i z POST masz je odbierać a nie z GET.


To tak jakbyś paczkę wysłał Pocztą Polską a następnie kazał czekać odbiorcy na przyjazd DHL.... Myśl troche chłopie

ok, ide kawe sobie zrobic i juz to zmieniam (IMG:style_emoticons/default/wink.gif) dziekuje za pomoc


nie dziala dalej, mam teraz pusta biala strone

Znaczy ze zrobiles blad. Pokaz cały kod po poprawkach

ja juz nie wiem, pomieszalo mi sie wszystko. prosze. moglbys to dla mnie naprawic?

to jest kod strony editdeletestudent.php: (ladnie pokazuje mi dane z student w tabelce z opcja edit i delete)

[PHP] pobierz, plaintext 
 <?php
 
// Connects to your Database 
 
mysql_connect("localhost", "root", "") or die(mysql_error());
 
mysql_select_db("glencaldy") or die(mysql_error());
 
 
//checks cookies to make sure they are logged in 
 
if (isset($_COOKIE['ID_my_site'])) {
    $username = $_COOKIE['ID_my_site'];
 
    $pass = $_COOKIE['Key_my_site'];
 
    $check = mysql_query("SELECT * FROM student WHERE username = '$username'") or die(mysql_error());
 
    while ($info = mysql_fetch_array($check)) {
        //if the cookie has the wrong password, they are taken to the login page 
 
        if ($pass != $info['password']) {
            header("Location: login.php");
 
        }
 
 
 
        //otherwise they are shown the admin area	 
 
        else {
            echo "<h1>DELETE/EDIT STUDENTS</h1><p>";
            $result = mysql_query("SELECT * FROM student") or die('Error');
 
            if (mysql_num_rows($result) > 0) {
                // if result is positive we display content
                echo "<table cellpadding=2 border=1>";
                while ($row = mysql_fetch_array($result)) {
                    echo "<tr>";
                    echo "<td>" . $row['studentid'] . "</td><td>" . $row['firstname'] . "</td><td>" . $row['surname'] . "</td>";
                    echo "<td> <a href=deletestudent2.php?a=del&amp;id={$row['studentid']}>DEL</a> 
       <a href=editstudent.php?a=edit&amp;id={$row['studentid']}>EDIT</a></td>";
                    echo "</tr>";
                }
                echo "</table>";
                echo "<br>";
                echo "<a href=menu.php><< Back to main menu</a><p>";
            }
        }
    }
}
 
else
//if the cookie does not exist, they are taken to the login screen 
    {
    header("Location: login.php");
 
}
 
?> 
[PHP] pobierz, plaintext 

to jest kod strony deletestudnet.php (kasuje rekordy z tabeli bez problemu):

[PHP] pobierz, plaintext 
 <?php
 
// Connects to your Database 
 
mysql_connect("localhost", "root", "") or die(mysql_error());
 
mysql_select_db("glencaldy") or die(mysql_error());
 
 
//checks cookies to make sure they are logged in 
 
if (isset($_COOKIE['ID_my_site'])) {
    $username = $_COOKIE['ID_my_site'];
 
    $pass = $_COOKIE['Key_my_site'];
 
    $check = mysql_query("SELECT * FROM student WHERE username = '$username'") or die(mysql_error());
 
    while ($info = mysql_fetch_array($check)) {
        //if the cookie has the wrong password, they are taken to the login page 
 
        if ($pass != $info['password']) {
            header("Location: login.php");
 
        }
 
 
 
        //otherwise they are shown the admin area	 
 
        else {
 
            $a  = trim($_GET['a']);
            $id = trim($_GET['id']);
 
            if ($a == 'del' and !empty($id)) {
                mysql_query("DELETE FROM student WHERE studentid='$id'") or die('Error.: ' . mysql_error());
                echo "<h1>DELETE STUDENT</h1><p>";
                echo 'Record deleted<br>';
                echo "<a href=menu.php><< Back to main menu</a><p>";
            }
        }
 
    }
}
 
else
//if the cookie does not exist, they are taken to the login screen 
    {
    header("Location: login.php");
 
}
 
?>
[PHP] pobierz, plaintext 

a to jest kod tej nieszczesnej strony editstudent.php (pokazuje dane w formularzu ale jak naciskam update records wywala mi biala strone i dane w bazie sie nie zmieniaja)

[PHP] pobierz, plaintext 
     <?php
 
    // Connects to your Database
 
    mysql_connect("localhost", "root", "") or die(mysql_error());
 
    mysql_select_db("glencaldy") or die(mysql_error());
 
 
    //checks cookies to make sure they are logged in
 
    if (isset($_COOKIE['ID_my_site'])) {
    $username = $_COOKIE['ID_my_site'];
 
    $pass = $_COOKIE['Key_my_site'];
 
    $check = mysql_query("SELECT * FROM student WHERE username = '$username'") or die(mysql_error());
 
    while ($info = mysql_fetch_array($check)) {
    //if the cookie has the wrong password, they are taken to the login page
 
    if ($pass != $info['password']) {
    header("Location: login.php");
 
    }
 
 
 
    //otherwise they are shown the admin area
 
    else {
    $a = trim($_REQUEST['a']);
	if(isset($_GET['id']))
    $id = trim($_GET['id']);
    else
    $id = '';
    if ($a == 'edit' and !empty($id)) {
    $result = mysql_query("SELECT * FROM student WHERE
    studentid='$id'") or die('Error');
 
    if (mysql_num_rows($result) > 0) {
    // read content of table
    $r = mysql_fetch_assoc($result);
    echo "<h1>EDIT STUDENT</h1><p>";
    echo '<form action="editstudent.php" method="post">
    <input type="hidden" name="a" value="save" />
    <input type="hidden" name="studentid" value="' . $id . '" />
    First name:<br />
    <input type="text" name="firstname"
    value="' . $r['firstname'] . '" /><br />
    Surname:<br />
    <input type="text" name="surname"
    value="' . $r['surname'] . '" /><br />
    Username:<br />
    <input type="text" name="username"
    value="' . $r['username'] . '" /><br />
    Password:<br />
    <input type="text" name="password"
    value="' . $r['password'] . '" /><br />
    <input type="submit" value="Update Record" />
    </form>';
    echo "<a href=deletestudent.php><< Back to delete/edit menu</a><p>";
    echo "<a href=menu.php><< Back to main menu</a><p>";
 
    }
 
    }
    }
 
    }
    } elseif ($a == 'save') {
    // get the new records from form
    $id = $_POST['studentid'];
    $firstname = trim($_POST['firstname']);
    $surname = trim($_POST['surname']);
    $username = trim($_POST['username']);
    $password = trim($_POST['password']);
    // update table
    mysql_query("UPDATE studnet SET firstname='$firstname',
    surname='$surname', username='&username', password='$password' WHERE studentid='$id'") or die('Error');
    echo 'records updated';
    }
 
    else
    //if the cookie does not exist, they are taken to the login screen
    {
    header("Location: login.php");
 
    }
 
    ?>
[PHP] pobierz, plaintext 

no i jest to zrobione GETem jednak (chyba sam juz nie wiem). prosze o spojrzenie w kod i pomoc

po usunieciu sprawdzania ciasteczek dziala wszystko ok:


ten kod dziala bez zarzutow ale jak chce sprawdzic ciasta to wywala na koniec pusta strone. jak tu dodac sprawdzanie ciastek teraz? jesli nie ma ciasta ma pokazywac login.php a jak sa to ma pokazywac tresc strony

[PHP] pobierz, plaintext 
 <?php
    // Connects to your Database
 
    mysql_connect("localhost", "root", "") or die(mysql_error());
 
    mysql_select_db("glencaldy") or die(mysql_error());
 
 
    $a = trim($_REQUEST['a']);
	if(isset($_GET['id']))
    $id = trim($_GET['id']);
    else
    $id = '';
    if ($a == 'edit' and !empty($id)) {
    $result = mysql_query("SELECT * FROM student WHERE
    studentid='$id'") or die('Error');
 
    if (mysql_num_rows($result) > 0) {
    // read content of table
    $r = mysql_fetch_assoc($result);
    echo "<h1>EDIT STUDENT</h1><p>";
    echo '<form action="editstudent.php" method="post">
    <input type="hidden" name="a" value="save" />
    <input type="hidden" name="studentid" value="' . $id . '" />
    First name:<br />
    <input type="text" name="firstname"
    value="' . $r['firstname'] . '" /><br />
    Surname:<br />
    <input type="text" name="surname"
    value="' . $r['surname'] . '" /><br />
    Username:<br />
    <input type="text" name="username"
    value="' . $r['username'] . '" /><br />
    Password:<br />
    <input type="text" name="password"
    value="' . $r['password'] . '" /><br />
    <input type="submit" value="save" />
    </form>';
 
    }
 
    }
      elseif ($a == 'save') {
    // get the new records from form
    $id = $_POST['studentid'];
    $firstname = trim($_POST['firstname']);
    $surname = trim($_POST['surname']);
    $username = trim($_POST['username']);
    $password = trim($_POST['password']);
    // update table
    mysql_query("UPDATE student SET firstname='$firstname',
    surname='$surname', username='&username', password='$password' WHERE studentid='$id'") or die('Error');
    echo 'records updated';
    }
 
    ?>
[PHP] pobierz, plaintext 

1. Zacznij od jakiegoś kursu PHP np. http://pl.wikibooks.org/wiki/PHP
2. Zdecyduj się w końcu czy używasz GET czy POST i do czego/w którym momencie.
3. Używaj var_dump jak czegoś nie wiesz, gdzie leży błąd sprawdzając zmienne.

ok, juz mi wszystko dziala jak powinno, logowanie do bazy dalem do odzielnego pliku, zrobilem porzadek w kodzie no i okazalo sie ze mialem nastepujace bledy 1) literowka w nazwie tabeli (IMG:style_emoticons/default/wink.gif) 2) zle domkniete klamry od sprawdzania ciastek.

dziekuje wszystkim za pomoc.

a o to poprawny kod.

[PHP] pobierz, plaintext 
  <?php
    // Connects to your Database
	require "connect.php";
	connection();
 
 
if (isset($_COOKIE['ID_my_site'])) {
    $username = $_COOKIE['ID_my_site'];
 
    $pass = $_COOKIE['Key_my_site'];
 
    $check = mysql_query("SELECT * FROM student WHERE username = '$username'") or die(mysql_error());
 
    while ($info = mysql_fetch_array($check)) {
        //if the cookie has the wrong password, they are taken to the login page 
 
        if ($pass != $info['password']) {
            header("Location: login.php");
 
        }
 
 
 
        //otherwise they are shown the admin area	 
 
        else {
 
    $a = trim($_REQUEST['a']);
    if(isset($_GET['id']))    $id = trim($_GET['id']);
    else
    $id = '';
    if ($a == 'edit' and !empty($id)) {
    $result = mysql_query("SELECT * FROM student WHERE    studentid='$id'") or die('Error');
 
    if (mysql_num_rows($result) > 0) {
    // read content of table
    $r = mysql_fetch_assoc($result);
	echo "<h1>EDIT STUDENT</h1><p>";
    echo '<form action="editstudent.php" method="post">
    <input type="hidden" name="a" value="save" />
    <input type="hidden" name="studentid" value="' . $id . '" />
    First name:<br />    <input type="text" name="firstname"
    value="' . $r['firstname'] . '" /><br />
    Surname:<br />
    <input type="text" name="surname"
    value="' . $r['surname'] . '" /><br />    Username:<br />
    <input type="text" name="username"
    value="' . $r['username'] . '" /><br />
    Password:<br />
    <input type="text" name="password"    value="' . $r['password'] . '" /><br />
    <input type="submit" value="save" />
    </form>';
	echo "<a href=deletestudent.php><< Back to delete/edit menu</a><br>";
    echo "<a href=menu.php><< Back to main menu</a><p>";
 
    }     
    }
    elseif ($a == 'save') {
    // get the new records from form
    $id = $_POST['studentid'];    $firstname = trim($_POST['firstname']);
    $surname = trim($_POST['surname']);
    $username = trim($_POST['username']);
    $password = trim($_POST['password']);
    // update table
	mysql_query("UPDATE student SET firstname='$firstname',
    surname='$surname', username='$username', password='$password' WHERE studentid='$id'") or die('Error');
	echo "<h1>EDIT STUDENT</h1><p>";
    echo '<i>Record Updated</i><p>';
	echo "<a href=deletestudent.php><< Back to delete/edit menu</a><br>";
    echo "<a href=menu.php><< Back to main menu</a><br>";
    }
 
 
 
	}
	}
	}
	else
//if the cookie does not exist, they are taken to the login screen 
    {
    header("Location: login.php");
 
}
         ?>
[PHP] pobierz, plaintext 

Ten post edytował dirtyhustlaz 19.11.2012, 20:17:46