[skrypt] [www] Skrypt/serwis ogłoszeń Opcje

[in5ane]

Witam, stworzyłem skrypt/serwis ogłoszeń. Jest to wersja 1.0 beta, więc mogą zdarzyć się jakieś krzaczki na stronie. Chciałbym, abyście dokonali oceny tego serwisu po przetestowaniu go. Chciałbym zaznaczyć, że jak spojrzycie w źródło, to zobaczycie troszeczkę bałaganu (uporządkuję to w przyszłości), dlatego tego proszę mi nie wytykać. Wygląd strony (grafika) wykonana przy użyciu CSS 3. Od razu również chcę podkreślić (wiem o tym), że strona troszeczkę kuleje na IE < 10, i wiem, że jest to do poprawy. Wiem, również, ze nie działa przypomnienie hasła oraz wiadomość do użytkownika (jakiś problem z funkcją mail() na serwerze, myślę nad tym, czemu nie działa).

Adres: http://jakubkubera.pl/ogloszenia/

Konta testowe:
1) login: kowalski@gmail.com, hasło: 123321
2) login: tester@tester.pl, hasło: 123321
3) login: tester@test.pl, hasło: 123321

Screen z panelu admina (jedna podstrona): http://jakubkubera.pl/ogloszenia/panel.jpg

W kolejnych wersjach planuję dodać możliwość płatności za ogłoszenie vip (tzn. promowane) za pomocą sms oraz dotpay. Również planuję dodać system reklam z rozbudowanym panel administracyjnym (zliczenia kliknięć, wyświetleń itp.). Kolejną rzeczą będzie możliwość wgrywania większej ilości zdjęć. Dodatkowo rozbudowanie wysyłania wiadomości do użytkownika. Poza tym możliwość (z pewnymi ograniczeniami) do dodawania ogłoszeń przez gości (opcja będzie miała możliwość włączenia i wyłączenia w panelu administracyjnym). To i pewnie jeszcze inne funkcje będę stopniowo dodawał w kolejnych wersjach.


Przyjmę każdą krytykę. I tę pozytywną i tę negatywną.

Pozdrawiam serdecznie.

Ten post edytował in5ane 8.02.2013, 10:44:02

[Tuminure]

Na głównej stronie przed najechaniem na slajder, jego podpis nie ma zaokrąglonych rogów. Po najechaniu na niego, rogi podpisu się zaokrąglają (w chrome).

Przyciski "Napisz wiadomość", "Szukaj" i "Zaloguj się" w ogóle nie przypominają czegokolwiek, co można kliknąć.

Do kategorii, regionów itp. przydałoby się wykorzystanie <label>, aby można było zaznaczyć checkboxa, poprzez klikanie na tekst. Zwijanie tych okienek jest bardzo nieintuicyjne - kursor myszy raczej sugeruje, że jest tam zwykły tekst.

Nie obsługujesz wszystkich błędów kohany (np. http://jakubkubera.pl/adverts/index.ph ) - swoją drogą, pokombinuj z ustawieniami tak aby wywalić index.php z adresu.

Ten post edytował Tuminure 7.02.2013, 14:42:13

[pyro]

CSSy i JS w ogóle nie działają.

[in5ane]

CSSy i JS w ogóle nie działają.

Nie rozumiem. O co chodzi?

[pyro]

No normalnie nie działają jakby ich w ogóle nie było -> Firefox.

[_Borys_]

W operze nie działają CSS-y, w firefoxie działają.
Opera 12.12
Firefox 17.0.1

edit
po wyłączeniu addblocka opera ładuje css, przedtem nie ładowała.

Ten post edytował _Borys_ 7.02.2013, 15:59:24

[in5ane]

No normalnie nie działają jakby ich w ogóle nie było -> Firefox.

Ja mam Firefoxa i są. Może wiesz, cóż to za przyczyna?

W operze nie działają CSS-y, w firefoxie działają.
Opera 12.12
Firefox 17.0.1

edit
po wyłączeniu addblocka opera ładuje css, przedtem nie ładowała.

Opery nie mam akurat, nie testowałem w niej. Czy może Ty również wiesz, czemu przy addblocku Opera nie ładuje CSS'ów?

[!*!]

HTTP_Exception_404 [ 404 ]: Unable to find a route to match the URI: adverts/index.php/offers/sejjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjvex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjjjjex.php/offers/sejjjjjjjjjjjjjjjjjjjjjjjjj

SYSPATH/classes/kohana/request.php [ 1126 ]
1121 */
1122 public function execute()
1123 {
1124 if ( ! $this->_route instanceof Route)
1125 {
1126 throw new HTTP_Exception_404('Unable to find a route to match the URI: :uri', array(
1127 ':uri' => $this->_uri,
1128 ));
1129 }
1130
1131 if ( ! $this->_client instanceof Request_Client)


DOCROOT/index.php [ 109 ] ? Kohana_Request->execute()
Environment

DOCUMENT_ROOT string(31) "/home/drukkse/public_html/jakub"
SCRIPT_FILENAME string(41) "/home/drukkse/public_html/jakub/index.php"
SCRIPT_NAME string(10) "/index.php"
SERVER_ADDR string(13) "109.73.163.86"
SERVER_ADMIN string(24) "webmaster@jakub.drukk.se"
SERVER_NAME string(14) "jakubkubera.pl"
SERVER_PORT string(2) "80"
SERVER_PROTOCOL string(8) "HTTP/1.1"
SERVER_SIGNATURE string(59) "<address>Apache Server at jakubkubera.pl Port 80</address>

Ten post edytował !*! 7.02.2013, 17:26:02

[in5ane]

@up: nie będę cytował bo za długie, ale pytanie do: !*!. Napisz, o co chodzi dokładnie. Pierwsza to wiem, że nie ma 404.

[_Borys_]

Ja mam Firefoxa i są. Może wiesz, cóż to za przyczyna?


Opery nie mam akurat, nie testowałem w niej. Czy może Ty również wiesz, czemu przy addblocku Opera nie ładuje CSS'ów?

Prawdopodobnie adblock blokuje jeśli w url-u jest adverts lub advert, u siebie nie mogę odczytać listy blokowanych słów ale w innych adblock-ach takie słowa występują w filtrach np
Fanboy's Adblock list

i podobnie jest pewnie w firefoxie jeśli ktoś ma włączony adblock.

[phpion]

Dziura w dziurze.

1. http://jakubkubera.pl/adverts/index.php/of...ge/id_o/1/id_u/
2.

A Database Error Occurred

Error Number: 1054

Unknown column 'dupa' in 'where clause'

SELECT * FROM offers WHERE category = dupa OR category = 2 AND state = 1 OR state = 2 AND date+(availability*24*60*60)>UNIX_TIMESTAMP() AND visibility = 1

Filename: /home/drukkse/public_html/jakub/adverts/models/offers_model.php

Line Number: 70

3.

A Database Error Occurred

Error Number: 1054

Unknown column 'dupa' in 'where clause'

SELECT * FROM offers WHERE category = 2 AND state = dupa OR state = 2 AND date+(availability*24*60*60)>UNIX_TIMESTAMP() AND visibility = 1

Filename: /home/drukkse/public_html/jakub/adverts/models/offers_model.php

Line Number: 70

Punkty 2 i 3 zrobiłem edytując wartości checkboxów Firebugiem. Dodatkowo na powyższych zapytaniach widać, że są błędne pod względem logicznym. Brakuje przecież nawiasów w ORach.

// Edit:
O proszę, jeszcze jedno:

A PHP Error was encountered

Severity: Warning

Message: Invalid argument supplied for foreach()

Filename: controllers/offers.php

Line Number: 220
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: libraries/Session.php

Line Number: 675
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: libraries/Session.php

Line Number: 675
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: libraries/Session.php

Line Number: 675
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: libraries/Session.php

Line Number: 675
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: libraries/Session.php

Line Number: 675
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: libraries/Session.php

Line Number: 675
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: libraries/Session.php

Line Number: 675
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: libraries/Session.php

Line Number: 675
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: libraries/Session.php

Line Number: 675
A PHP Error was encountered

Severity: Warning

Message: Cannot modify header information - headers already sent by (output started at /home/drukkse/public_html/jakub/adverts/system/core/Exceptions.php:185)

Filename: core/Common.php

Line Number: 438
A Database Error Occurred

Error Number: 1064

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND state = 2 AND date+(availability*24*60*60)>UNIX_TIMESTAMP() AND visibility' at line 1

SELECT * FROM offers WHERE AND state = 2 AND date+(availability*24*60*60)>UNIX_TIMESTAMP() AND visibility = 1

Filename: /home/drukkse/public_html/jakub/adverts/models/offers_model.php

Line Number: 70

Swoją drogą: po błędach wygląda na to, że apka to mix Kohany i Code Ignitera. Tak jest czy tylko mi się tak wydaje? Możliwe, że Twoja strona domowa jest na Kohanie i stąd takie różne rodzaje błędów.

[!*!]

@up: nie będę cytował bo za długie, ale pytanie do: !*!. Napisz, o co chodzi dokładnie. Pierwsza to wiem, że nie ma 404.

Nie chodzi o to że nie ma 404, tylko że uri było za długie i cały skrypt szlag trafił. Drugi cytat to rozwinięcie pierwszego z którego można wyczytać ciekawe rzeczy, a które nie powinny być widoczne, tak samo jak te z uri, jak i te co napisał mój przedmówca.
Bo niby po co ktoś miałby wiedzieć ze serwer stoi na apache, a Twój login do niego to drukkse.

[in5ane]

Swoją drogą: po błędach wygląda na to, że apka to mix Kohany i Code Ignitera. Tak jest czy tylko mi się tak wydaje? Możliwe, że Twoja strona domowa jest na Kohanie i stąd takie różne rodzaje błędów.

Na Kohanie jest strona domowa (była zrobiona na Kohanie dla testów). Rozumiem te błędy, pozabezpieczam je.

[pyro]

Ja mam Firefoxa i są. Może wiesz, cóż to za przyczyna?

Kolega ma problem w Operze, a ja w Firefoksie, w którym również mam ADBlocka, więc pewnie to jest przyczyną.

Forum dla programistów, a tak mało ludzi korzysta z ADBlocka? Ludzie, wtyczka niebo. (IMG:style_emoticons/default/zakochany.gif)

Ten post edytował pyro 7.02.2013, 23:48:06

[in5ane]

Kolega ma problem w Operze, a ja w Firefoksie, w którym również mam ADBlocka, więc pewnie to jest przyczyną.

Forum dla programistów, a tak mało ludzi korzysta z ADBlocka? Ludzie, wtyczka niebo. (IMG:style_emoticons/default/zakochany.gif)

A może to wina, że strona jest w katalogu "adverts"?

[Wicio]

W Chrome z włączonym AdBlockiem faktycznie ani CSS'y, ani JS'y się nie wyświetlały. Po wstrzymaniu ochrony i odświeżeniu strony problem magicznie zniknął. Sądzę, że problem leży w podkatalogu w którym znajduje się strona.

[in5ane]

W Chrome z włączonym AdBlockiem faktycznie ani CSS'y, ani JS'y się nie wyświetlały. Po wstrzymaniu ochrony i odświeżeniu strony problem magicznie zniknął. Sądzę, że problem leży w podkatalogu w którym znajduje się strona.

Ot co, zmieniam katalog.

Obecny adres strony to: http://jakubkubera.pl/ogloszenia/.

@edit: poprawiłem również wyświetlanie w IE. Nadal mam problem z Google Chrome z border-radius, które na stronie głównej robi się dopiero po najechaniu na obrazek. Ale z tego, co czytałem na jednym z zagranicznych for, to -webkit-border-radius ma bug, ale zastanawiam się, czy to na pewno to i czy ewentualnie nie można tego ominąć.

Ten post edytował in5ane 8.02.2013, 10:45:44

[pyro]

A Database Error Occurred

Unable to connect to your database server using the provided settings.

Filename: core/Loader.php

Line Number: 346

Jak na frameworka to na razie same błędy widzę (IMG:style_emoticons/default/tongue.gif)

[lukaskolista]

Blad bazy danych (IMG:style_emoticons/default/sad.gif)

[in5ane]

Ojejciu, wgrywałem stronę na serwer. Już działa. Bez takich, co? (IMG:style_emoticons/default/biggrin.gif)

@edit: naprawiona dziura w podstronie message (z wiadomościami do użytkownika) (IMG:style_emoticons/default/smile.gif) Działam sobie dalej po troszku, jak mam czas (IMG:style_emoticons/default/smile.gif)

Ten post edytował in5ane 8.02.2013, 10:55:27