[PHP Front Controller i Router Opcje

[walus16]

Witam, napisałem właśnie do swojego frameworka Front Controller i Router. Chciałbym prosić was o opinię co mógł bym z optymalizować lub poprawić. Wiem, że człowiek nie jest nieomylny, dlatego wasze spostrzeżenia będą dla mnie bardzo cenne.

frontcontroller.php

[PHP] pobierz, plaintext 
<?php defined('BASEPATH') OR exit('No direct script access allowed.');
 
require_once SYS_PATH . 'core/controller.php';
require_once SYS_PATH . 'core/router.php';
 
class Bootstrap
{
	public function init(Router $router)
	{
		$controller = $router->getController();
		$method = $router->getAction();
		$params = $router->getParams();
 
		require_once APP_PATH . 'config/config.php';
 
		$controller = $controller ? $controller : DEFAULT_CONTROLLER;
		$method = $method ? $method : DEFAULT_ACTION;
 
		$path_controller = APP_PATH . 'controllers/' . $controller . '.php';
 
		if (file_exists($path_controller)) {
			require_once $path_controller;
 
			$controller = new $controller();
 
    		        if (method_exists($controller, $method)) {
        		        return call_user_func(array($controller, $method), $params);
   		        } 
   		        echo '404 not found - method';
		} else {
			echo '404 not found - controller';
		}
	}
}
[PHP] pobierz, plaintext 

router.php

[PHP] pobierz, plaintext 
<?php defined('BASEPATH') OR exit('No direct script access allowed.');
 
class Router
{
	protected $controller;
	protected $action;
	protected $params;
 
	public function __construct()
	{
		$path_info = !empty($_SERVER['PATH_INFO']) ? $_SERVER['PATH_INFO'] : (!empty($_SERVER['ORIG_PATH_INFO']) ? $_SERVER['ORIG_PATH_INFO'] : '');
 
		$path_info = array_filter(explode('/', $path_info));
		$origin = implode('/', $path_info);
 
		require APP_PATH . 'config/routes.php';
 
		foreach ($route as $key => $value) {
 
			$key = str_replace(
				array(':any', ':num', ':nonum', ':alpha', ':alnum', ':hex'), 
				array('[^/]+', '[0-9]+', '[^0-9]+', '[A-Za-z]+', '[A-Za-z0-9]+', '[A-Fa-f0-9]+'),
				$key
			);
 
    		if (preg_match('#^' . $key . '$#', $origin)) {
				$origin = preg_replace('#^' . $key . '$#', $value, $origin);
			}
		}
 
		$parts = explode('/', $origin);
		$parts2 = array_filter($parts);
 
		$this->controller = ($c = array_shift($parts)) ? $c : 'welcome';
		$this->action = ($c = array_shift($parts)) ? $c : 'index';
 
		// Params
 
		$this->params = (isset($parts2[2])) ? $parts2[2] : null;
 
 		//echo $this->getController() . ',' . $this->getAction() . ',' . $this->getParams() . '<br />';
 
 	}
 
 	public function getController()
 	{
 		return $this->controller;
 	}
 
 	public function getAction()
 	{
 		return $this->action;
	}
 
	public function getParams()
	{
		return $this->params;
	}
}
[PHP] pobierz, plaintext 

Ten post edytował walus16 10.10.2014, 07:35:22