[PHP]Sprawdzenie klasy Opcje

[minolone]

Witam.
Prosze was o sprawdzenie klasy oraz wyrzucenie mi wszystkich błędów co jest nie tak jak być powinno.
Jest nie skończona ale wszytsko działa tak jak chciałem.

[PHP] pobierz, plaintext 
<?php
 
    print_r($_POST);
 
    class AirConditioning {
 
        const HOME = 20; 
        const HOME_ROOF = 0.2;
        const COMPANY = 10;
        const COMPANY_PERCENT = 0.1;
        const COMPANY_ROOF = 0.1;
        const PEOPLE = 0.1;
 
        private $people;
        //public $window;
        private $roof;
 
        public function __construct($room, $height, $area, $people, $window, $roof) {
            $this->room = $room;
            $this->height = $height;
            $this->area = $area;
            if(!empty($window)) $this->window = $window;
            if(!empty($people)) $this->people = $people;
            if(!empty($roof)) $this->roof = $roof;
        }
 
        public function check() {
            if($this->room == 0) {
                return $this->home($this->height, $this->area);
            }
            if($this->room == 1) {
                return $this->company($this->height, $this->area);
            }
        }
 
        public function home($height, $area) {
            $count = $height*$area/self::HOME;
 
            if($this->roof == 1) {
                $roof = self::HOME_ROOF;
            }
 
            if($this->people > 0) {
                $people = $this->people($this->people);   
            }
 
            if(isset($roof) AND $roof > 0) {
                $count = $count+$count*$roof;
            }
 
            if(isset($people) AND $people > 0) {
                $count = $count+$people;
            }
 
            return $count;
        }
 
        public function company($height, $area) {
            $count = $height*$area;
            $count = $count/self::COMPANY;
            $add = self::COMPANY_PERCENT;
 
            if($this->roof == 1) {
                $add += self::COMPANY_ROOF;
            }
 
            if($this->people > 0) {
                $people = $this->people($this->people);   
            }
 
            if(isset($roof) AND $roof > 0) {
                $count = $count+$count*$roof;
            }
 
            if(isset($people) AND $people > 0) {
                $count = $count+$people;
            }
 
            return $count;
        }
 
        public function people($people) {
            $people = $people*self::PEOPLE;
            return $people;
        }
 
    } 
 
?>
[PHP] pobierz, plaintext 

[rocktech.pl]

Witam.

Trochę szczegółów, komentarze, przykłady użycia poprosimy.

Na ten moment PHP_CodeSniffer (IMG:style_emoticons/default/smile.gif)

[BASH] pobierz, plaintext 
phpcs AirConditioning.class.php 
 
FILE: AirConditioning.class.php
--------------------------------------------------------------------------------
FOUND 25 ERROR(S) AND 3 WARNING(S) AFFECTING 22 LINE(S)
--------------------------------------------------------------------------------
  2 | ERROR   | Missing file doc comment
  5 | ERROR   | Missing class doc comment
  5 | ERROR   | Opening brace of a class must be on the line after the
    |         | definition
 14 | ERROR   | Private member variable "people" must be prefixed with an
    |         | underscore
 16 | ERROR   | Private member variable "roof" must be prefixed with an
    |         | underscore
 18 | ERROR   | You must use "/**" style comments for a function comment
 18 | ERROR   | Opening brace should be on a new line
 22 | WARNING | Inline control structures are discouraged
 23 | WARNING | Inline control structures are discouraged
 24 | WARNING | Inline control structures are discouraged
 27 | ERROR   | Missing function doc comment
 27 | ERROR   | Opening brace should be on a new line
 28 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 31 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 36 | ERROR   | Missing function doc comment
 36 | ERROR   | Opening brace should be on a new line
 39 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 43 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 47 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 51 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 58 | ERROR   | Missing function doc comment
 58 | ERROR   | Opening brace should be on a new line
 63 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 67 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 71 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 75 | ERROR   | Expected "if (...) {\n"; found "if(...) {\n"
 82 | ERROR   | Missing function doc comment
 82 | ERROR   | Opening brace should be on a new line
--------------------------------------------------------------------------------
[BASH] pobierz, plaintext 

Ten post edytował rocktech.pl 11.01.2012, 15:10:23