Forum PHP.pl

Witam!

Czy takie logowanie jest w miare bezpieczne? Jeśli nie co jest nie tak? Za pomoc z góry dziękuję

[PHP] pobierz, plaintext 
<?php
 
  if($_SESSION['userId'] > 1)  
  { 
    header('Location: /index.php');
  }        
  else {
 
  $user      = filter($_POST['login']);
  $password  = md5(filter($_POST['password']));  
  $query     = mysql_query(' SELECT * FROM `users` WHERE userLogin="'.query($user).'" AND userPassword="'.query($password).'" AND userActive="yes" ');
 
  if($query && mysql_num_rows($query) == 1)
  {
    while($row = mysql_fetch_array($query))      
    {
        session_start();          
        if (!isset($_SESSION['initiate']))          
        {                   
          session_regenerate_id();              
          $_SESSION['initiate']           = true;
          $_SESSION['initiate']           = $new;
          $_SESSION['address_ip']         = $_SERVER['REMOTE_ADDR'];
          $_SESSION['userId']             = $row['userId'];
          $_SESSION['userLogin']          = $row['userLogin'];
          $_SESSION['userPassword']       = $row['userPassword'];                    
          $_SESSION['userActive']         = $row['userActive']; 
          $_SESSION['userGroup']          = $row['userGroup']; 
          $_SESSION['userName']           = $row['userName']; 
          $_SESSION['userSurname']        = $row['userSurname'];    
          $_SESSION['userCity']           = $row['userCity'];  
          $_SESSION['userPhoneNumber']    = $row['userPhoneNumber']; 
          $_SESSION['userEmail']          = $row['userEmail']; 
          $_SESSION['userGGNumber']       = $row['userGGNumber']; 
          $_SESSION['userAboutMe']        = $row['userAboutMe'];  
          $_SESSION['userDateBirth']      = $row['userDateBirth']; 
 
          $_SESSION['userHideDateBirth']  = $row['userHideDateBirth'];   
          $_SESSION['userHideSurname']    = $row['userHideSurname'];    
          $_SESSION['userHidePhoneNumber']= $row['userHidePhoneNumber']; 
          $_SESSION['userHideEmail']      = $row['userHideEmail']; 
          $_SESSION['userHideGGNumber']   = $row['userHideGGNumber']; 
          $_SESSION['userHideAboutMe']    = $row['userHideAboutMe'];  
 
          $_SESSION['userLastLogin']      = $row['userLastLogin'];  
          $_SESSION['userLastLoginIP']    = $row['userLastLoginIP'];
 
          mysql_query(' UPDATE `users` SET userLastLogin="'.query(date('Y-m-d H:i:s')).'"           WHERE userId="'.query($_SESSION['userId']).'" LIMIT 1');
          mysql_query(' UPDATE `users` SET userLastLoginIP="'.query($_SERVER['REMOTE_ADDR']).'"     WHERE userId="'.query($_SESSION['userId']).'" LIMIT 1');
 
          header('Location: /myAccount');                                 
        }
    }
  }
  else
    { 
      systemMessage('Logowanie', 'Prawdopodobnie podałeś zły login, lub hasło.', '', '', 'login', 'Spróbuj ponownie się zalogować', '', '', '', 'COMMUNIQUE_ERROR');
    }
}
 
?>
[PHP] pobierz, plaintext